Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DataServer to use plate-model-manager #135

Open
brmather opened this issue Nov 13, 2023 · 5 comments · May be fixed by #141
Open

Modify DataServer to use plate-model-manager #135

brmather opened this issue Nov 13, 2023 · 5 comments · May be fixed by #141
Assignees
Labels
enhancement New feature or request high
Milestone

Comments

@brmather
Copy link
Collaborator

We should encourage people to use the plate-model-manager, as @michaelchin is doing for the notebooks, but we should also adapt the existing DataServer object to use plate-model-manager under the hood so that we don't upset existing GPlately users. We can always deprecate DataServer in the future if we need to.

@michaelchin - I'm not sure if this is already an option, but can plate-model-manager download files to the user's cache directory?

@brmather brmather self-assigned this Nov 13, 2023
@michaelchin
Copy link
Contributor

@michaelchin - I'm not sure if this is already an option, but can plate-model-manager download files to the user's cache directory?

Yes, the plate-model-manager can save the files to user-specified folder.

@michaelchin
Copy link
Contributor

We should encourage people to use the plate-model-manager, as @michaelchin is doing for the notebooks, but we should also adapt the existing DataServer object to use plate-model-manager under the hood so that we don't upset existing GPlately users. We can always deprecate DataServer in the future if we need to.

Yes, this is a good idea. Another option is to keep both for a while. The plate-model-manager is new and maybe have some bugs. If we keep DataServer as it is, users have the option to fall back to DataServer if the plate-model-manager does not work for them.

@michaelchin
Copy link
Contributor

Maybe print deprecated message when users use DataServer to encourage them to switch to the new plate-model-manager.

@michaelchin
Copy link
Contributor

Hi @brmather

Are you still on this? I can finish this if you like.

@michaelchin michaelchin self-assigned this Jun 13, 2024
@michaelchin michaelchin added enhancement New feature or request high labels Jun 13, 2024
@michaelchin michaelchin removed their assignment Jun 14, 2024
@michaelchin
Copy link
Contributor

this issue is related to #149

@michaelchin michaelchin pinned this issue Jun 14, 2024
@michaelchin michaelchin added this to the release 2.0.0 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants