Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 issues with sds-table #1148

Closed
knamburigsa opened this issue Mar 31, 2023 · 0 comments · Fixed by #1545
Closed

508 issues with sds-table #1148

knamburigsa opened this issue Mar 31, 2023 · 0 comments · Fixed by #1545
Assignees

Comments

@knamburigsa
Copy link

Components Involved
sds-table
508 testing is done against the table and following issues are brought up. I was able reproduce most of the issues in sam-design-system demo page.

Kitchen sink example on table demo page: https://cg-fa19003e-5296-4960-ac2e-caccfeb620ac.sites.pages.cloud.gov/site/gsa/sam-design-system/documentation/components/table/examples
https://cg-fa19003e-5296-4960-ac2e-caccfeb620ac.sites.pages.cloud.gov/site/gsa/sam-design-system/assets/stackblitzes/table/full/stackblitz.html

Expected Behavior
How you expect the listed component(s) to function

  1. Saved search table is not formatted right. There should not be a empty column, when you go down it should not go Action button. The header column for the expand/collapse button should add some text context.
  2. The expand button should not be skipped.
  3. The Order of the button list, should matching the order visually.
  4. Expand/Collapse column should have a name.

Actual Behavior
How the listed component(s) actually function

  1. Saved search table is not formatted right. There should not be a empty column, when you go down it should not go Action button. The header column for the expand/collapse button should add some text context.
  2. The expand button is completely skipped.
  3. The Order of the button list, is not matching the order visually.
  4. Expand/Collapse column does have a name.

Your Environment
Angular Version: X.Y.Z
@gsa-sam packages version: X.Y.Z (Please list individually if all packages are not same version)
image

Ticket Number
Please provide your JIRA ticket number that is dependent on this fix. If there is none, please create
one to validate the issue once the fix has been released. DO NOT provide the url, please ONLY
provide the ticket number.
IAE-XYZ

Additional context
Screenshots / recordings, minimal reproduction on stackblitz, steps to reproduce, code snippets, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants