Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable 2.2.0.0 Update Major Issues #10930

Closed
27 tasks done
Connor-Colenso opened this issue Aug 5, 2022 · 54 comments
Closed
27 tasks done

Stable 2.2.0.0 Update Major Issues #10930

Connor-Colenso opened this issue Aug 5, 2022 · 54 comments

Comments

@Connor-Colenso
Copy link
Contributor

Connor-Colenso commented Aug 5, 2022

Your GTNH Discord Username

Colen

Information

A stable is soon approaching, in preparation for this we are putting together a list of major issues requiring resolution prior to this. Please comment any issues you feel deserve to be on this list and we will absorb them if we feel they are essential.

Description

@hoshinokiseki
Copy link
Contributor

so will you repair "Could not get provider type for dimension 32" error? this error leads to crash. even 2.1.2.4 has bettercrash mod, it still can cause another question.

@Glease
Copy link
Contributor

Glease commented Aug 5, 2022

@hoshinokiseki Please link the issue you are mentioning. If there isn't one, please create a new ticket for it.

@miozune
Copy link
Member

miozune commented Aug 5, 2022

I guess they mean #10377 and similar crash when teleporting

@chochem
Copy link
Member

chochem commented Aug 5, 2022

@Glease not (just) teleporting. I can consistently reproduce #10377 by leaving my sp world to main menu and starting a fresh world without client restart.

@Glease
Copy link
Contributor

Glease commented Aug 5, 2022

Might be related GTNewHorizons/Galacticraft#49

@combusterf
Copy link
Contributor

Botania's *wood and *stone don't fit typical gregtech materials, and were absent from the issues that asked for compat materials. These might just as well be reverted again if they cause issues.

@chochem
Copy link
Member

chochem commented Aug 5, 2022

  1. I think these 2 errors should probably be fixed (or hidden if harmless :P) for a stable release OC Error in chat on startup as of dev17 #10663
  2. Kevlar is still untested which might be fine to push to later as it has no use yet either. But I have one open ticket arising from it that affects other stuff, namely a nitrobenzene recipe with slightly different ingredients and in the LCR, that should not exist imo: Nitrobenzene issues #10650 . Best consult dream though before 'fixing' as I still dont know what exactly he is thinking there and he added it.

@miozune
Copy link
Member

miozune commented Aug 5, 2022

It is possible to fix rotor issue while keeping livingwood / livingrock materials. The problem is whether we want plates and other oreprefixes of Botania materials or not. How do you think? @Dream-Master

@combusterf
Copy link
Contributor

combusterf commented Aug 5, 2022

We also have the more typical ingots and gems with all the corresponding GT versions (which seem to not be an issue), the difference being that those are actually in use, so it's really about (not) dropping integration with Botania's stones and woods.

@Steelux8
Copy link
Contributor

Steelux8 commented Aug 5, 2022

The entire Kevlar line needs to be properly reviewed before the next stable. Even if Kevlar itself isn't used for anything, that line brought some hidden buffs and changes, like the buff to oil processing in DTs, the earlier nitrobenzene recipe, and it might have others that we haven't found yet.

@xSkewer
Copy link
Contributor

xSkewer commented Aug 5, 2022

image
This recipe in the Kevlar line being circuit-less conflicts with some people's setups for other lines (mainly Polyphenylene Sulfide), so it should be removed/given a circuit before stable.

@Steelux8
Copy link
Contributor

Steelux8 commented Aug 5, 2022

Yet another problematic recipe in the kevlar line. We need to scour the entire thing and make a list, and then put in this ticket.

@Dream-Master Dream-Master unpinned this issue Aug 5, 2022
@Dream-Master Dream-Master pinned this issue Aug 5, 2022
@GlodBlock
Copy link
Contributor

what oil buff?

@Dream-Master
Copy link
Member

It is possible to fix rotor issue while keeping livingwood / livingrock materials. The problem is whether we want plates and other oreprefixes of Botania materials or not. How do you think? @Dream-Master

i would keep materials

@Steelux8
Copy link
Contributor

Steelux8 commented Aug 5, 2022

what oil buff?

When the circuits were added to the DT recipes, for the new chemicals used in the Kevlar line, some of the new oil processing recipes were faster than the ones before, not the same speed.

@Dream-Master
Copy link
Member

image This recipe in the Kevlar line being circuit-less conflicts with some people's setups for other lines (mainly Polyphenylene Sulfide), so it should be removed/given a circuit before stable.

what i see in the recipe ?

@Dream-Master
Copy link
Member

what oil buff?

i add a second recipe you get more out of oil (LCR recipe with 9x oil but better outputs)

@xSkewer
Copy link
Contributor

xSkewer commented Aug 5, 2022

what i see in the recipe ?

This is the recipe for Sulfur Dichloride, made from Sulfur Dust and Chlorine.

@Florexiz
Copy link
Contributor

Florexiz commented Aug 5, 2022

We also lost most assembler rotor recipes
image

@Connor-Colenso
Copy link
Contributor Author

We also lost most assembler rotor recipes image

Any idea why this occurred? A specific PR? I was under the impression most people used the extruder for this anyway.

@Florexiz
Copy link
Contributor

Florexiz commented Aug 5, 2022

Most likely related to GTNewHorizons/GT5-Unofficial#1208
For some reason validation fails

@Flanisch
Copy link

Flanisch commented Aug 5, 2022

https://bugs.mojang.com/browse/MC-132488

Don't know how applicable this is in regards to the FPS lag. It would require the render optimizations from VanillaFix to be backported to 1.7.

@chochem
Copy link
Member

chochem commented Aug 6, 2022

please add to the list the wyvern/aw drac/chaotic cores are currently uncraftable. Boubou seems to be working on it and alternatively there is the option of a temporary quest for the schematics (see draft pr), but this needs to be resolved in some form before the stable version.

@miozune
Copy link
Member

miozune commented Aug 6, 2022

Weird, I do have the recipes. Are you on GT5 runClient? GT5 alone does not register rotors much
2022-08-06_12 16 40

@chochem
Copy link
Member

chochem commented Aug 6, 2022

sadly I got another one: #10939
The gt industrial apiary cannot be used for breeding right now and with the new WA restrictions for other options, that is just a massive unintended nerf to bees.

@chochem
Copy link
Member

chochem commented Aug 11, 2022

If someone can look at this one #10973 before stable that would be great too. pretty annoying to breed bees or build certain multis if you dont get the name of the block you need.

Edit: fixed now for the multis, just not bees.
Edi2: fully fixed.

@chochem
Copy link
Member

chochem commented Aug 13, 2022

@Connor-Colenso wouldnt it be easier to just demand indalloy for all high tier circuit recipes including single block? (crystal/wetware/bio+asoc)
So just change the normal circuit assembler recipe and bartworks will probably just transfer that to CAL.

well I think I'll try that

@eigenraven
Copy link
Member

The personal space issue turned out to be a problem with the multiverse plugin config which is now removed from zeta.

@chochem
Copy link
Member

chochem commented Aug 14, 2022

obvious addition: #11017

@Runakai1
Copy link
Contributor

#11050

Think that's important too if it seems to not be an user Error.

@chochem
Copy link
Member

chochem commented Aug 19, 2022

I think this one would be pretty nice for stable too: #10271
I think the loading screens are manual work though right? Some new ones would be great too. :)

@Dream-Master
Copy link
Member

I think this one would be pretty nice for stable too: #10271 I think the loading screens are manual work though right? Some new ones would be great too. :)

ill take care when we assembled final version

@Dream-Master
Copy link
Member

image This recipe in the Kevlar line being circuit-less conflicts with some people's setups for other lines (mainly Polyphenylene Sulfide), so it should be removed/given a circuit before stable.

image
it has a circuit

@chochem
Copy link
Member

chochem commented Aug 20, 2022

yea Glod added that circuit

@Dream-Master
Copy link
Member

ok all issues fixed so far beside the cell color bug

@Dream-Master
Copy link
Member

And i add new Loading Screen Graphics

@chochem
Copy link
Member

chochem commented Aug 22, 2022

this still needs more testing but AE being broken is very bad for a stable: #11102, #11075

@albertopirillo
Copy link

Let me add that for the next stable the old EC2 quests should be removed and new quests about AE2FC should be introduced

@chochem
Copy link
Member

chochem commented Aug 22, 2022

Let me add that for the next stable the old EC2 quests should be removed and new quests about AE2FC should be introduced

please make a ticket propose some then

@albertopirillo
Copy link

Done #11106

@chochem
Copy link
Member

chochem commented Aug 23, 2022

Many ++ structure checks were fixed by GTNewHorizons/GTplusplus#294 so I put the checkmark there. But its absolutely possible glee8e and me missed some.

@YannickMG
Copy link
Contributor

Added #11114

@Sphyix
Copy link

Sphyix commented Sep 4, 2022

This wasn't fixed yet, #10048
Any chance it can get fixed before release?
I'm able to reproduce on 29-dev, adding it now on the ticket

EDIT
Nvm, probably fixed but i'm dumb, I'll keep testing and update on ticket

@Steelux8
Copy link
Contributor

Steelux8 commented Sep 7, 2022

mega ABS needs to be finished. I've done all the structure work, and some code work, but I haven't implemented multi-amp hatches, nor have I done the balancing decisions for the multi.

@chochem chochem closed this as completed Sep 7, 2022
@chochem chochem reopened this Sep 7, 2022
@chochem
Copy link
Member

chochem commented Sep 7, 2022

sorry for the misclick. just wanted to write a comment:

I think megaABS can just happen after stable, no reason to delay for it that I can see.

@Steelux8
Copy link
Contributor

Steelux8 commented Sep 7, 2022

The reason the PR was made was that Alk really wanted the ABS to have its limitations, and started the mega version to give an alternative. If the mega itself isn't finished, then that conversation about the input buses of the ABS needs to be.

@Dream-Master
Copy link
Member

we have to do a vote or make a community decision. I don't want that alk force us here. If the majority think the abs limitation is not good balanced in gtnh we change that. Even if alk is against it.

@Dream-Master
Copy link
Member

The Mega ABS can be added next version or in the dev version after 2.2.0.0

@Dream-Master
Copy link
Member

#11236

@chochem
Copy link
Member

chochem commented Oct 3, 2022

since 2.2.0.0 is out I guess we can close this

@chochem chochem closed this as completed Oct 3, 2022
@chochem chochem unpinned this issue Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests