Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Remove INpureCore Mod #17002

Closed
4 tasks done
slprime opened this issue Aug 14, 2024 · 6 comments
Closed
4 tasks done

Suggestion: Remove INpureCore Mod #17002

slprime opened this issue Aug 14, 2024 · 6 comments
Labels
Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. Type: Suggestion

Comments

@slprime
Copy link
Member

slprime commented Aug 14, 2024

Your GTNH Discord Username

SLPrime

Your Pack Version

nightly

Your Proposal

I suggest removing this mod and transferring the remaining functionality to NEI

Your Goal

This mod hide items in NEI, such as:
image

but it doesn't use NEI's plugin mechanism or any other way to tell NEI that it's finished. This leads to the fact that the entire list of items is recreated several times (the number depends on many conditions)

Your Vision

I suggest adding in NEI the ability to hide items at the modpack config, and remove this mod.

  1. This will increase the speed of the first draw of NEI
  2. Will allow find a way to cache a list of items
  3. This mod uses javascript? didn't expect that

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this change please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
  • I understand this change request may not attract enough attention and thus not be implemented.
  • I understand this change request may be rejected due to other community members think it's inappropriate.
  • I believe this feature would make the pack better.
@slprime slprime added Type: Suggestion Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. labels Aug 14, 2024
@Caedis
Copy link
Member

Caedis commented Aug 14, 2024

Who doesnt love doing minecraft mods in javascript?

@slprime
Copy link
Member Author

slprime commented Aug 14, 2024

Who makes such decisions?

@chochem
Copy link
Member

chochem commented Aug 14, 2024

either approval from boubou or dream would be good I guess

@boubou19
Copy link
Member

input core is here to remove the clutter from NEI, and was added back then because we had no ways to do it, and it was an out of the box mod, just a config change and voilà, items are hidden. Now we have both skill and manpower required to do this, so if in addition of this it increases performances, there is absolutely no reason not to do this change.

@Caedis
Copy link
Member

Caedis commented Aug 14, 2024

:shipit:

@slprime
Copy link
Member Author

slprime commented Aug 14, 2024

ok then i'll get to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Tasks awaiting triage. Removed once a dev confirms the issue as valid. Type: Suggestion
Projects
None yet
Development

No branches or pull requests

4 participants