Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests exercising each error code #31

Open
plaidfinch opened this issue Nov 14, 2019 · 1 comment
Open

Add unit tests exercising each error code #31

plaidfinch opened this issue Nov 14, 2019 · 1 comment
Assignees
Labels
Cryptol Related to Cryptol API in particular Low-Hanging Fruit Good first task to meet the code Python Related to the Python clients to the APIs SAW Related to SAW API in particular
Milestone

Comments

@plaidfinch
Copy link
Contributor

We want to make sure the errors we expect are the ones we get, so it would be good to add some expected-to-fail unit tests.

@plaidfinch plaidfinch added Low-Hanging Fruit Good first task to meet the code SAW Related to SAW API in particular Cryptol Related to Cryptol API in particular Python Related to the Python clients to the APIs labels Nov 14, 2019
@david-christiansen david-christiansen added this to the Nice to have milestone Apr 8, 2020
@pnwamk pnwamk self-assigned this Oct 7, 2020
@pnwamk
Copy link
Contributor

pnwamk commented Oct 13, 2020

Commit 5dcb409 has partially addressed this (via unit tests in the file-echo-api unit tests), however, the below listed error codes could still use some manual checks.

N.B., some of these error codes may be better tested directly (i.e., from a simple Haskell unit test) if the relevant portion of the python argo API is designed to only send correct, well-formed requests.

This was referenced Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cryptol Related to Cryptol API in particular Low-Hanging Fruit Good first task to meet the code Python Related to the Python clients to the APIs SAW Related to SAW API in particular
Projects
None yet
Development

No branches or pull requests

3 participants