Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use What4.Serialize.Parser to parse solver models/values. #228

Open
andreistefanescu opened this issue Dec 20, 2022 · 1 comment
Open

Use What4.Serialize.Parser to parse solver models/values. #228

andreistefanescu opened this issue Dec 20, 2022 · 1 comment
Assignees

Comments

@andreistefanescu
Copy link
Contributor

andreistefanescu commented Dec 20, 2022

The SMT-LIB2 parsing code in What4.Protocol.SMTLib2 (parseDefineFun/parseLambda) is copy-pasted and adapted from What4.Serialize.Parser. Changes:

  • What4.Protocol.SExp.SExp instead of What4.Serialize.Printer.SExpr
  • SMT-LIB2 operators (and/+/...) instead of the What4.Serialize operators (andp/intmul/...)
  • operator left/right associativity
  • define-fun/lambda syntax instead of definedfn
@andreistefanescu andreistefanescu self-assigned this Dec 20, 2022
@andreistefanescu andreistefanescu mentioned this issue Dec 20, 2022
@RyanGlScott
Copy link
Contributor

Relatedly, the return type for the runGetAbducts function is a list of Strings, rather than something like an Expr, as we didn't have the capability to parse solver values at the time runGetAbducts was added. If we unify the treatment of our parsers, a next logical step would be to change runGetAbducts to return something more structured than Strings. (See this discussion.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants