Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImageButton bool return value for pressed #259

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Fix ImageButton bool return value for pressed #259

merged 2 commits into from
Sep 9, 2019

Conversation

repi
Copy link
Contributor

@repi repi commented Sep 9, 2019

This was a regression in 0.2.0, in that large change the build function lost its return value so one couldn't check if the image button had been pressed or not.

Would it be possible to have a 0.2.1 published on crates.io with this fix?

@repi
Fix ImageButton bool return value for pressed.
4cde7ca 
This was a regression in 0.2.0
@repi repi mentioned this pull request Sep 9, 2019
Open
26 tasks
@Gekkio
Copy link
Contributor

Gekkio commented Sep 9, 2019

Thanks! 😄

Yeah, I'll release 0.2.1 of imgui + imgui-winit-support later today

@Gekkio Gekkio merged commit 2c31ab4 into imgui-rs:master Sep 9, 2019
@repi repi deleted the fix-image-button-press branch September 14, 2019 11:42
@repi repi restored the fix-image-button-press branch September 14, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repi @Gekkio