Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints incorrect number of chains for JointModelSamples #356

Closed
gravesti opened this issue Jun 17, 2024 · 0 comments · Fixed by #362
Closed

Prints incorrect number of chains for JointModelSamples #356

gravesti opened this issue Jun 17, 2024 · 0 comments · Fixed by #362
Assignees
Labels
bug Something isn't working

Comments

@gravesti
Copy link
Collaborator

Printing a JointModelSamples object appears to have the wrong number of chains

mp <-  sampleStanModel(
            jm,
            data = jdat,
            iter_sampling = 1000,
            iter_warmup = 1000,
            chains = 3,
            parallel_chains = 4
        )
mp

prints

   JointModelSamples Object with:
  
      # of samples per chain = 1000
      # of chains            = 1
  
      Variables:
          beta_os_cov[3]
          link_coefficients
          ...

but I expect number of chains should be 3.

This comes from

as.CmdStanMCMC(object)$metadata()$num_chains

and I think it should be

 as.CmdStanMCMC(object)$num_chains()

eg

as.CmdStanMCMC(mp)$num_chains()
[1] 3
@gowerc gowerc added the bug Something isn't working label Jun 17, 2024
@gowerc gowerc added this to the Initial Internal Release milestone Jun 17, 2024
@gowerc gowerc self-assigned this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants