Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scatter plots gallery example colourblind friendly #1011

Closed
weiji14 opened this issue Mar 6, 2021 · 5 comments · Fixed by #1013
Closed

Make scatter plots gallery example colourblind friendly #1011

weiji14 opened this issue Mar 6, 2021 · 5 comments · Fixed by #1013
Labels
a11y Accessibility - so that more people can enjoy bug Something isn't working first-timers-only For absolute beginners
Milestone

Comments

@weiji14
Copy link
Member

weiji14 commented Mar 6, 2021

Description of the problem

The orange and green colours at the "Scatter plots with a legend" gallery example can be hard to distinguish for people with red/green colour vision deficiencies. We should choose different colours instead if possible.

v0.3.0 original colour Deuteranopia (no green) simulation
original colour Deuteranopia simulation

The line that needs to change is this:

for color in ["blue", "orange", "green"]:

References:

@weiji14 weiji14 added bug Something isn't working first-timers-only For absolute beginners a11y Accessibility - so that more people can enjoy labels Mar 6, 2021
@ria-19
Copy link

ria-19 commented Mar 8, 2021

Can I work on this issue?

@weiji14
Copy link
Member Author

weiji14 commented Mar 8, 2021

Hi @ria-19, this issue is already being worked on already at #1013. But you can find a list of other issues at https://github.com/GenericMappingTools/pygmt/contribute that we need help with. I recommend #908 which is not taken yet, though you're welcome to try another one too.

@ria-19
Copy link

ria-19 commented Mar 8, 2021

Okay, Thank you!

@nathandloria
Copy link
Contributor

Hello! Recently my group @munzekm @cklima616 @noorbuchi and I took up work on #1070. We did this work for a class and another cycle has recently begun in that same class. We noticed that there was previously work being done on this issue, however progress seems to have slowed. Our team would love to take up work on this issue if possible. We really enjoyed this project and would love to continue contributing to pygmt!

@seisman
Copy link
Member

seisman commented Apr 2, 2021

@nathandloria Thanks for your interest in this issue. I just pinged the original author of PR #1013. I'd like to give another one week to see if the author wants to keep working on that PR before you create a new one.

@seisman seisman added this to the 0.4.0 milestone Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility - so that more people can enjoy bug Something isn't working first-timers-only For absolute beginners
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants