Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Three tests fail with GMT dev versions #968

Closed
seisman opened this issue Feb 26, 2021 · 0 comments · Fixed by #970
Closed

Three tests fail with GMT dev versions #968

seisman opened this issue Feb 26, 2021 · 0 comments · Fixed by #970
Labels
bug Something isn't working help wanted Helping hands are appreciated
Milestone
0.3.1

Comments

@seisman
Copy link
Member

seisman commented Feb 26, 2021 •
edited by weiji14
Loading

See https://github.com/GenericMappingTools/pygmt/actions/runs/601427126 for the recent PyGMT tests with GMT dev versions.

Three tests failed due the recent upstream changes (possibly GenericMappingTools/gmt#4852) and our static out-of-date baseline images:

../tests/test_basemap.py::test_basemap_winkel_tripel FAILED              
../tests/test_basemap.py::test_basemap_aliases FAILED
../tests/test_plot.py::test_plot_projection FAILED

We need to rewrite the three tests using the @check_figures_equal decorator, but also welcome to join discussions in #963.
@seisman seisman added bug Something isn't working help wanted Helping hands are appreciated labels Feb 26, 2021
@weiji14 weiji14 mentioned this issue Feb 26, 2021
Merged
5 tasks
@seisman seisman added this to the 0.3.1 milestone Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Helping hands are appreciated
Projects
None yet
Milestone
0.3.1
Development

Successfully merging a pull request may close this issue.

Fix three tests failing with GMT dev version GenericMappingTools/pygmt
1 participant
@seisman