Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in CRA v4 #9

Closed
sahilpurav opened this issue Nov 24, 2020 · 2 comments
Closed

Error in CRA v4 #9

sahilpurav opened this issue Nov 24, 2020 · 2 comments

Comments

@sahilpurav
Copy link

@GeoffSelby With the latest version of CRA (v4), we've started getting following error:

craco: *** Cannot find ESLint loader (eslint-loader). ***

Looking at the overall thread on here, craco team doesn't seem to be interested in fixing it. May be we should think about switching from Craco to more native solution which is closer to CRA native method.

There is already a pull request available at CRA that allows adding postcss.config.js with the option to override the default config. Once this is launched, we should think about moving away from craco. Thoughts?

@sahilpurav sahilpurav changed the title Error after CRA v4 Error in CRA v4 Nov 24, 2020
@GeoffSelby
Copy link
Owner

I will look into this some more later. I don't think the PR to add postcss.config.js to CRA will be merged. It's been discussed before and never happened. I'll likely try to fix craco first because I often use its other features as well so it would be nice to have. I'll update you when I know more.

@sahilpurav
Copy link
Author

Well, in that case, you don't really need to fix anything, as soon as craco team is fixing this issue - dilanx/craco#205 You just have to update the package :) If you want you can close this issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants