-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: A post causes a UI overflow on Tuba App #914
Comments
That's not it (or at least it's doesn't reproduce it here) In general, the issue is with GtkLabel + ellipsize + wrap measuring the widget size incorrectly. GtkLabels are beyond broken under multiple containers, see this one for another example #756 (comment) It has been reported again #719 and again #632 and again #626 and many other times, but unless I get the post (or rather label) actually causing it, reproducibly, I can't really do anything, including creating a minimal reproduction so gtk fixes it or a workaround from our side Finding which one is actually causing it is also somewhat difficult as you have to play around with the inspector until you figure it out, which is likely to crash a few times. I don't expect anyone to go through that but I'm still throwing it out there just in case |
Though, from the looks of it you are also using an older version of Tuba, it might have been fixed on 0.7 🤷 |
Ahh, thanks for that. You are correct, that was the wrong post. I think I found the correct post that causes it: https://fosstodon.org/deck/@[email protected]/112287918084026585 |
It looks like since this is a duplicate, it doesn't make sense to keep open. |
Thanks for figuring it out! I'll re-open this as they are mostly case-by-case. I'll see about writing a workaround! |
Okay so, GtkLabel reports a larger min width that natural. This can be fixed by removing the overflow workaround but then we need to fix that. So for now, I'll say blocked by https://gitlab.gnome.org/GNOME/gtk/-/issues/6637 and see how it goes |
This post also messes up the layout for me: https://misskey.fryer.net.au/notes/9zi3esm0yk |
Can reproduce, thanks! |
I'm just going to post this here for future reference:
|
Ahem... I still hope to eventually fix all of this from GTK side, once and for all. But evidently this is taking longer than expected, and I understand that you want to ship a non-broken app now (which I as a user only appreciate). But please avoid doing anything (e.g.: designing LWW to fundamentally rely on hacks) that would prevent you from just doing the supported, straightforward thing in the future, once |
Thanks, I appreciate all your work on fixing GtkLabel 🙇 As it stands, #1172 is not that big of a deal, it just changes wrapping from word_char to word. It might cause wrapping to not be as nice as it was but it's preferred over having your whole timeline broken just because of a single post
Well, the obvious one would be, adding custom widgets but... it's a very niche use that is more likely to make GtkLabel even more complex. So the second best solution, would probably be unsealing GtkLabel so I can freely manipulate its aria label and measuring, but I don't think anyone involved will be interested in that 😅 Other than that, if you go deep into pango stuff, And RTL languages are not always detected (?) #16, I can't remember the specifics, this was very early in tuba's lifespan, but I ended up using a regex and set xalign manually |
Describe the bug
Hello!
This post seems to cause an overflow of the UI of the Tuba App: https://akkoma.meows.gay/objects/b0dcc9c5-ece9-49eb-a83a-7c2b8b60c1bd
Screenshot:
Steps To Reproduce
Logs and/or Screenshots
Instance Backend
Mastodon
Operating System
Debian Trixie
Package
OS repositories
Troubleshooting information
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: