Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do you think of git-ignoring Godeps? #2

Open
dashmug opened this issue May 13, 2016 · 2 comments
Open

What do you think of git-ignoring Godeps? #2

dashmug opened this issue May 13, 2016 · 2 comments

Comments

@dashmug
Copy link

dashmug commented May 13, 2016

Third-party party libraries should probably be vendored and and only referenced in the Godep.json but not committed to version control as what tools/godep#131 suggests.

But then vendoring 3rd-party libs will also make you vulnerable when the hosts of those libs change just like what happened when http://code.google.com got discontinued.
http://stackoverflow.com/questions/26334220/should-i-commit-godeps-workspace-or-is-godeps-json-enough

@alur222
Copy link
Contributor

alur222 commented May 14, 2016

+1

@GermanMontejo
Copy link
Owner

GermanMontejo commented May 15, 2016

@dashmug thanks for your input! I was only able to notice this now (facepalm).
Yes, I should include godeps in git ignore. On second thought, I may not have any need to include godeps (and just have to remove it here) because I didn't use any third party packages in this project. What do you think, @dashmug ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants