fix: handle issue with process and DOM conflict #1331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Any DOM element with an id can be accessed from the window object by
window.{EL_ID}
.Also, global variables are available without chaining window object. e.g.
variableName // global variable
is the same aswindow.variableName
Therefore if a page contains a DOM element with id "process" the client constructor check
typeof process !== "undefined"
is not sufficient.process.env.ANY_ENV_VARIABLE
will throw the TypeErrorTypeError: process.env is undefined
that crashes the messenger.Changelog