Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty bottom sheet shown while the app resumes from the background #2663

Open
andreicrat opened this issue Sep 10, 2024 · 1 comment
Open

Comments

@andreicrat
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

We've seen a strange behavior that an empty bottom sheet has been displayed after the app resumed from the background with a different orientation.

Steps to reproduce:

  1. Use the chat display threads
  2. Put the app in landscape mode
  3. Put the app in the background
  4. Put the phone in portrait mode again and open the app - you'll see an empty bottom sheet of the attachments picker.

Here is the diff that solved my problem:

diff --git a/node_modules/stream-chat-react-native-core/src/components/AttachmentPicker/AttachmentPicker.tsx b/node_modules/stream-chat-react-native-core/src/components/AttachmentPicker/AttachmentPicker.tsx
index 2399593..4d46a64 100644
--- a/node_modules/stream-chat-react-native-core/src/components/AttachmentPicker/AttachmentPicker.tsx
+++ b/node_modules/stream-chat-react-native-core/src/components/AttachmentPicker/AttachmentPicker.tsx
@@ -264,7 +264,7 @@ export const AttachmentPicker = React.forwardRef(
     return (
       <>
         <BottomSheet
-          containerHeight={fullScreenHeight}
+          // containerHeight={fullScreenHeight}
           enablePanDownToClose={true}
           handleComponent={
             /**

This issue body was partially generated by patch-package.

@khushal87
Copy link
Member

Hey @andreicrat, do you see how containerHeight would cause a problem here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants