Fix load faraday/mutipart error #67
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for this and thank you for the PR! We now require conventional commits for this repo. Could you please change your commit message to something like |
|
@ffenix113 |
|
For now it's fine, thank you. Tests are failing because of the secrets used in tests. Thank you for your contribution! |
Merged
|
@kyohah this is now released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
In gemspec, the version of faraday is not locked, so when I added the gem, the latest faraday was installed and LoadError faraday/multipart was raised.
https://github.com/lostisland/faraday/blob/9825916400379e4dc1bf8616a57b53f5200958bd/UPGRADING.md#so-what-should-i-do-if-i-currently-use-the-retry-or-multipart-middleware