Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve identification of binaries #841

Open
agateau-gg opened this issue Jan 22, 2024 · 0 comments
Open

Improve identification of binaries #841

agateau-gg opened this issue Jan 22, 2024 · 0 comments
Labels
status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working

Comments

@agateau-gg
Copy link
Collaborator

Environment

  • ggshield version: 1.23.0
  • Operating system (Linux, macOS, Windows): Linux
  • Operating system version: Ubuntu 22.04
  • Python version: Python 3.10

Describe the bug

When iterating on a directory or a Docker image, ggshield often hits binaries, like executable files. We should not try to scan these files by default, at least until #396 is done.

Steps to reproduce:

  1. Scan a directory containing binaries, such as /usr/bin on a Unix system (ggshield secret scan path -ry /usr/bin)
  2. Notice ggshield tries to detect the encoding of the files

Expected result:

ggshield should silently skip binary files.

@agateau-gg agateau-gg added type:bug Something isn't working status:new This issue needs to be reviewed status:confirmed This issue has been reviewed and confirmed and removed status:new This issue needs to be reviewed labels Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed This issue has been reviewed and confirmed type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant