Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libgit2sharp to 0.24+ to fix path issues with escape sequences #1415

Closed
nlowe opened this issue May 30, 2018 · 2 comments
Closed

Update libgit2sharp to 0.24+ to fix path issues with escape sequences #1415

nlowe opened this issue May 30, 2018 · 2 comments

Comments

@nlowe
Copy link

nlowe commented May 30, 2018

libgit2sharp can't load the native DLL if the path contains %2F, which happens frequently on Jenkins when building pipelines in nested folders.

libgit2/libgit2sharp#1389 was fixed in libgit2/libgit2sharp#1409, which appears to be in 0.24+. It looks like GitVersion master is still targeting a prerelease of 0.23. Any chance we can upgrade to 0.24+ and cut a release? I'd be happy to send a PR if that is acceptable.

We can work around this by setting a customWorkspace on the Jenkins node definition, but I'd really like to not have to update all my builds with custom workspace naming logic just to get nice versioning.

@nlowe
Copy link
Author

nlowe commented May 30, 2018

It seems like #1248 may solve this.

@asbjornu
Copy link
Member

After upgrading to LibGit2Sharp 0.26 in #1713, I hope this problem is fixed. Please try the latest build of GitVersion and report back whether it fixes this problem or not. Reopen this issue if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants