Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional output type for saving asserted version numbers to a file #983

Closed
gep13 opened this issue Jul 28, 2016 · 7 comments · Fixed by #2251
Closed

Add additional output type for saving asserted version numbers to a file #983

gep13 opened this issue Jul 28, 2016 · 7 comments · Fixed by #2251
Assignees
Labels
Milestone

Comments

@gep13
Copy link
Member

gep13 commented Jul 28, 2016

It would allow some consistency when calling GitVersion with /output buildserver where the variables are not output to the stdout, since this is not possible.

We are already creating the cache file on each run, so it should be simple enough to take a file path from the user, and save the file there also.

As discussed on Gitter here:

https://gitter.im/GitTools/GitVersion?at=5799fe2c93148c6b21e580a5

@kritisingh1
Copy link

@gep13 Hi. I would like to work on this issue. Please let me know if I may. I am a beginner and this would be my first contribution to open source.

@asbjornu
Copy link
Member

asbjornu commented Jun 8, 2017

@kritisingh1: Awesome! Please go ahead and:

  1. Fork the repository
  2. Create a new branch
  3. Commit the fixes to the branch
  4. Push the branch to your remote fork
  5. Create a pull request

If you have any questions, don't hesitate to ask them here or on Gitter.

@WhiteWaterCoder
Copy link

Is this issue still up for grabs? I might try and have a stab at it in my minimal spare time.

@asbjornu
Copy link
Member

@WhiteWaterCoder: Yes, absolutely! That would be awesome!

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Apr 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 2, 2020
@asbjornu asbjornu removed the stale label Apr 2, 2020
@asbjornu asbjornu added this to the 5.3.0 milestone Apr 6, 2020
@github-actions
Copy link

github-actions bot commented May 4, 2020

🎉 This issue has been resolved in version 5.3.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants