-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please refer to igraph instead of python-igraph #223
Comments
Unfortunately this change will break the conda packaging pipeline for cdlib. Pip and conda dependencies need to have the same signature since the conda skeleton is automatically generated from the pip package. Is the name update planned also for the conda release? |
No, it is unfortunately not. See conda-forge/python-igraph-feedstock#42 for the discussion. |
To be clear, it'll probably be a while before |
In my opinion this choice will end up damaging the developer community: basically in this way you are preventing automated skeleton building pipelines for conda packaging of those projects relying on igraph. It is not exactly a "friendly" behaviour in Free Software/Open Source communities. Moreover, I don't see the urgency in changing the package name apart from a stylistic perspective... This was an easily avoidable breaking change. My suggestion: have a pip installable meta-package that maintains the old name and points to the new one until the naming across package managers will be uniformed. This way the installation stats for igraph will be more reliable and developers using it on their libraries will be spared from additional cross packaging nightmares. |
To give some background: The change was not purely for stylistic reasons. On PyPI, Note that Conda is not a Python package manager. It is a general purpose one. It includes the C, Python and R interfaces of igraph, all of which are named "igraph" in their upstream repositories. Such multi-system package managers will inevitably need to find a way to differentiate between packages of the same name coming from different backgrounds. Thus, on Conda there is both Similar issues affect all other generic package managers and Linux distros, which have their own typical naming conventions. You can see some of the choices they made here for Python and here for R. Regarding practical issues: The primary name on PyPI will be |
I knew the background. However, the issue still remains. And the proposed solution is by matter of fact stylistic and has repercussions. Indeed conda is a "general" package manager but several pipy distributed packages have (name)synced conda ones. And breaking such convention breaks also automated packaging (and some ci/cd) pipelines. Of course, maintainers are not compelled to enforce such customary naming pattern, however, as discussed, deviations might produce downstream issues (maybe not for normal users, for sure for other maintainers having projects with multiple packaging channels relying on non name aligned dependencies). Although I understand the maintainers decision, I still think it was not particularly "friendly" w.r.t. their community. |
@GiulioRossetti might it not be possible to simply create a separate feedstock on As @szhorvat explains, there is a good reason for having different names on |
Can you please change
python-igraph
toigraph
in locations wherepip
(not conda!) may take package names? I believe these are:https://github.com/GiulioRossetti/cdlib/blob/master/requirements.txt#L16
and maybe this:
https://github.com/GiulioRossetti/cdlib/blob/master/docs/conf.py#L55
Please see igraph/python-igraph#699 for an explanation.
Ref: https://github.com/search?q=repo%3AGiulioRossetti%2Fcdlib%20python-igraph&type=code
The text was updated successfully, but these errors were encountered: