Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When zooming, the glyphs should smoothly move towards the glyph they are merged into, or smoothly move away from the glyph they split from #12

Open
kabverbeek opened this issue Mar 12, 2018 · 2 comments
Assignees

Comments

@kabverbeek
Copy link

We don't know if this is easily possible in the current setup, but this would be preferred over the "preview" option implemented in the earlier version of glammap, where with a mouseover you could see into which multiple glyphs a particular glyph would split when zooming in.

@Tommos0
Copy link
Member

Tommos0 commented Mar 15, 2018

Currently glyphs are implemented as Leaflet layers. This means Leaflet controls their position (and scale, although it is broken now). Actual position on the screen is a complex mix of css transforms of the parent panel (in which the map layers is also situated) and the glyphs themselves.

Implementing this while we are using Leaflet layers will mean we battle Leaflet for position control (read: struggle & bugs). Alternatively we control an overlay ourselves. This means complete flexibility to do what we want, although it will cause some difficulties synchronizing zoom / panning (especially during transitions) with the map layer. I think the best option is to just try and see what problems arise.

@Tommos0 Tommos0 self-assigned this Mar 15, 2018
@Tommos0
Copy link
Member

Tommos0 commented Mar 15, 2018

On second hand, it's easier to nest the glyph one more level and (animate) move the intermediate element. We need to predict though what in pixels the new position will be after a zoom action, but this is much more feasible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants