New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLanguages by extension is not working #353

Closed

2 tasks done

Glavin001 opened this issue May 20, 2015 · 2 comments

Closed

2 tasks done

getLanguages by extension is not working #353

Glavin001 opened this issue May 20, 2015 · 2 comments

Assignees

Labels

Milestone

Owner

Glavin001 commented May 20, 2015

Fix the following typos/bugs:

The extensions in the Languages are omitting the prefix . (period) while the extensions returned from path.extname are with the . prefix. This of course causing the lookup by extension to fail. See

atom-beautify/src/beautifiers/index.coffee

Line 296 in bb3b9c9

fileExtension = path.extname(filePath)
getLanguages expects extension not fileExtension. See

atom-beautify/src/beautifiers/index.coffee

Line 297 in bb3b9c9

languages = @languages.getLanguages({grammar, fileExtension})

The text was updated successfully, but these errors were encountered:

Glavin001 added the bug label

Glavin001 self-assigned this

Glavin001 added this to the v0.28.0 milestone

Owner Author

Glavin001 commented May 20, 2015

This is causing the problem at #144 (comment)

Glavin001 mentioned this issue

adds .js to the extensions supported by the jsx language #348

Merged

Glavin001 closed this as completed in

559c2ec

Owner Author

Glavin001 commented May 20, 2015

Published to v0.27.4

Glavin001 added the published label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment