From 5533b9350adc1244dfb40afe0bc96df752c38cb3 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Fri, 20 Aug 2021 12:25:03 -0500 Subject: [PATCH] don't include all of @types/node for Buffer.from().toString() --- report/renderer/logger.js | 4 ++-- report/renderer/report-ui-features.js | 2 +- report/tsconfig.json | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/report/renderer/logger.js b/report/renderer/logger.js index 76b4aa6f063e..3d0595c63668 100644 --- a/report/renderer/logger.js +++ b/report/renderer/logger.js @@ -40,7 +40,7 @@ export class Logger { this.el.textContent = msg; this.el.classList.add('show'); if (autoHide) { - this._id = setTimeout(_ => { + this._id = setTimeout(() => { this.el.classList.remove('show'); }, 7000); } @@ -61,7 +61,7 @@ export class Logger { // Rethrow to make sure it's auditable as an error, but in a setTimeout so page // recovers gracefully and user can try loading a report again. - setTimeout(_ => { + setTimeout(() => { throw new Error(msg); }, 0); } diff --git a/report/renderer/report-ui-features.js b/report/renderer/report-ui-features.js index ce6644e94927..f699543645c6 100644 --- a/report/renderer/report-ui-features.js +++ b/report/renderer/report-ui-features.js @@ -705,7 +705,7 @@ export class ReportUIFeatures { // cleanup. this._document.body.removeChild(a); - setTimeout(_ => URL.revokeObjectURL(a.href), 500); + setTimeout(() => URL.revokeObjectURL(a.href), 500); } /** diff --git a/report/tsconfig.json b/report/tsconfig.json index 4f7ea0daba86..c81ff3c9e88c 100644 --- a/report/tsconfig.json +++ b/report/tsconfig.json @@ -7,8 +7,8 @@ // Limit to base JS and DOM defs. "lib": ["es2020", "dom", "dom.iterable"], - // Include `@types/node` for use of `Buffer` in text-encoding.js. - "types": ["node"], + // Don't include any node_module types. + "types": [], "target": "es2020", "module": "es2020", "moduleResolution": "node",