-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing evaluation heading: "Address bar matches brand colors" #1106
Comments
Ah we only care that it's defined, but we don't need anything to "match". Yes. agree the wording isn't ideal. Maybe...
|
@kaycebasques wdyt on the name here. we just want these colors defined somewhere. that's it. And honestly we have no idea what your REAL brand colors are. :) |
hi i uesd these and this inside my style : {"theme_color": "#228f21" ...} but i will get Address bar does not match brand colors (The browser address bar can be themed to match your site.) what i have to do for fixing this ? |
@pardismusic have you read the documentation? Do you have the meta tag? |
hi but i add 2 space between |
You don't have a manifest @pardismusic. https://developers.google.com/web/tools/lighthouse/audits/manifest-exists#recommendations |
i really didnt undrestand how to make manifest is there any video to showing that ? or any site example |
Yes the documentation links to a guide https://developers.google.com/web/fundamentals/web-app-manifest/ |
fixed in #6494! |
When generating a report on this URL, Lighthouse suggests that the address bar matches the brand colors:
In actuality, the site's manifest.json has:
The HTML
theme-color
is matched by the manifest'sbackground_color
, but the manifesttheme_color
is different (#FFFFFF, and Android renders the notification area in grey color).Related: #25.
The text was updated successfully, but these errors were encountered: