Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-flags snapshots fail depending on how you run them #13875

Closed
brendankenny opened this issue Apr 19, 2022 · 0 comments · Fixed by #13922
Closed

cli-flags snapshots fail depending on how you run them #13875

brendankenny opened this issue Apr 19, 2022 · 0 comments · Fixed by #13922
Assignees

Comments

@brendankenny
Copy link
Member

yarn unit-cli causes a bunch of snapshot errors from #13596 like

  ● CLI flags › screenEmulation › disabled › parses the flag with no value as true

    expect(received).toMatchSnapshot()

    Snapshot name: `CLI flags screenEmulation disabled parses the flag with no value as true 1`

    - Snapshot  - 1
    + Received  + 1

    @@ -1,7 +1,7 @@
      Object {
    -   "$0": "node_modules/jest/bin/jest.js",
    +   "$0": "node_modules/jest-worker/build/workers/processChild.js",
        "_": Array [
          "http://www.example.com",
        ],
        "channel": "cli",
        "chrome-flags": "",

I assume that line can be ignored as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants