Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report generated time is always in en-US #1703

Closed
XhmikosR opened this issue Feb 12, 2017 · 4 comments
Closed

Report generated time is always in en-US #1703

XhmikosR opened this issue Feb 12, 2017 · 4 comments
Labels
bug i18n internationalization thangs needs-discussion P1.5

Comments

@XhmikosR
Copy link
Contributor

C:\Users\xmr\Desktop>@systeminfo | @findstr /B /C:"System Locale" /B /C:"Input Locale" /B /C:"Time Zone"
System Locale:             el;Greek
Input Locale:              en-us;English (United States)
Time Zone:                 (UTC+02:00) Athens, Bucharest

Yet the date in the reports is always in English US format.

Generated by Lighthouse 1.5.1 on 2/12/2017, 2:13:03 PM GMT+2

I find it confusing being that I'm not used to the US date format.

@paulirish
Copy link
Member

Aye. Confirming that in https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/report/v2/renderer/util.js we always render it in en-us, though we do use the local timezone.

It started here #206 (comment)

AFAIK there isn't a reason why we force en-us. We should leave it as undefined to pick up the local locale.

@wardpeet
Copy link
Collaborator

wardpeet commented Dec 2, 2018

We can now run lighthouse for your locale by using the locale option in the cli.

node lighthouse-cli/index.js https://www.paulirish.com --locale el-GR or run lighthouse on pagespeed insights.

@paulirish we could enable multi locale support on lighthouse-viewer so people can override the defined locale. WDYT?

@exterkamp
Copy link
Member

We now default the renderer to 'en' otherwise read from config settings afaik. +1 to letting the viewer detect if there is a diff in report locale and local locale and give a conversion option maybe? Or the choice of locale?

@brendankenny
Copy link
Member

Yeah, confirmed that with the explicit --locale=el the time is now correctly formatted.

I added bullet points to the i18n umbrella bug #7238 for being able to swap the locale in the viewer and investigate looking at system info for determining the locale to use automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n internationalization thangs needs-discussion P1.5
Projects
None yet
Development

No branches or pull requests

6 participants