Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: URL is not a constructor #5701

Closed
wardpeet opened this issue Jul 20, 2018 · 1 comment
Closed

TypeError: URL is not a constructor #5701

wardpeet opened this issue Jul 20, 2018 · 1 comment
Assignees
@wardpeet
Labels
bug Sentry seo

Comments

@wardpeet
Copy link
Collaborator

wardpeet commented Jul 20, 2018 •
edited
Loading

Some sites seems to override the URL property with a string or not a constructor which means our robots.txt cannot be fetched. We should guard us against URL injection like we do for promises.

https://sentry.io/google-lighthouse/lighthouse/issues/495524891/

TypeError: URL is not a constructor
  File "<anonymous>", line 6, in getRobotsTxtContent
  File "<anonymous>", line 16, in __nativePromise.resolve.then._

TypeError: URL is not a constructor
@wardpeet wardpeet self-assigned this Jul 20, 2018
@wardpeet wardpeet mentioned this issue Jul 28, 2018
Merged
@brendankenny
Copy link
Member

fixed in #5748!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wardpeet wardpeet

Labels
bug Sentry seo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendankenny @wardpeet