Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility false reports regarding <dl>, <dd>, and <dt> #5940

Closed
RoryDuncan opened this issue Aug 31, 2018 · 2 comments · Fixed by #7020
Closed

Accessibility false reports regarding <dl>, <dd>, and <dt> #5940

RoryDuncan opened this issue Aug 31, 2018 · 2 comments · Fixed by #7020

Comments

@RoryDuncan
Copy link

Lighthouse's Accessibility sections is reporting — and marking down — the following html structure, claiming it fails the 'Elements are Well-Structured' test.

  <dl>
    <div>
      <dt>VIN dt</dt>
      <dd>VIN dd</dd>
    </div>
    <div>
      <dt>VIN dt</dt>
      <dd>VIN dd</dd>
    </div>
  </dl>

The above abides by specification for the <dl> tag:

The dl element represents a description list of zero or more term-description groups. Each term-description group consists of one or more terms (represented by dt elements) possibly as children of a div element child, and one or more descriptions (represented by dd elements possibly as children of a div element child)**, ignoring any nodes other than dt and dd element children, and dt and dd elements that are children of div element children within a single dl element.

Steps to reproduce

  1. Run LH on https://s.codepen.io/RoryDuncan/debug/wEgEWR/NjkYzqWobpBM
  2. Go to Elements are Well-Structured section of Accessibility.
  3. Observe warnings listed.

Resulting Report:

image

Case that Screen Readers may produce confusing or inaccurate output

Both ChromeVox and Windows Narrator skip over

elements completely. 🤷‍♂️

@justinribeiro
Copy link
Contributor

Hi thanks for the issue! This is specific to aXe, which LH uses behind the scenes to handle accessibility audits.

In the case you mention, there's an upstream bug that was recently merged that resolves this dequelabs/axe-core#262 and there is an open PR that bumps LH's aXe version up bring it up to date, which ideally will include said fix: #5565

@RoryDuncan
Copy link
Author

oh cool, thanks for the info, Justin. 😄
I subscribed to that pull request — I'll close this when it has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants