report: ✅ audits should be in Passed Audits

[paulirish]

Can't really explain why the dom-size audit isn't in passed:

i mean i can because i originally wanted it to work this way:

lighthouse/lighthouse-core/report/html/renderer/util.js

Lines 145 to 148 in e07a94b

	// Numeric audits that are within PASS_THRESHOLD will still show up with failing.
	// For opportunities, we want to have them show up with other failing for contrast.
	// For diagnostics, we sort by score so they'll be lowest priority.
	return Number(audit.score) === 1;

but its annoying and just leads to confusion.

we should just use RATINGS.PASS.minScore instead.

[brendankenny]

Are we covering up the underlying bug? The 0ms results should always pass Number(audit.score) === 1, so it seems like something else is going on with LR.

(the other side of this, hiding passed audits under "Passed Audits" seems fine, though)

[paulirish]

@brendankenny afaik, that is a separate bug: #5956. right??

[midzer]

@paulirish yes, I just opened PR #5983 for this one