-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: produce LHR when error is thrown during gather-runner #6330
Comments
I don't mind gracefully handling errors, but we have I think it's a different situation than in LR where we always need something that fits something like the LHR shape, including in the cases of complete errors. For the other clients I'd rather have a nice message telling me the error (with am exit code for the CLI) rather than getting an empty report with a big error box at the top. |
yesh |
requires non trivial refactoring of gather-runner#run
Non-CLI entry points handle errors being thrown adequately, but the CLI simply prints the error without creating a LHR. @paulirish would like to see errors handled more gracefully. @brendankenny has opinions, too.
Opening this ticket to track any conversation for/against.
Relates to #6300
The text was updated successfully, but these errors were encountered: