Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Lighthouse from the Extension incorrectly reports missing form labels #7224

Closed
calder12 opened this issue Feb 12, 2019 · 3 comments
Closed

Comments

@calder12
Copy link

Provide the steps to reproduce

  1. Run LH on https://calder.io from the Chrome Browser Extension.
  2. Run LH from Chrome developer tools Audit tab

What is the current behavior?

When running from the Extension, Lighthouse reports that the form elements have no associated labels (they do), but when running from developer tools LH reports correctly.

What is the expected behavior?

Both the extension, and the developer tools audit, show produce the same results.

Environment Information

  • Lighthouse version: 4.0.0 (the one giving the wrong report from the extension)
  • Lighthouse version: 3.2.0 (the one running from Chrome dev tools)
  • Operating System: Windows 10
@patrickhulce
Copy link
Collaborator

Thanks @calder12! I can confirm this behavior with axe-core 3.1.2. Would you mind filing this in the appropriate repository (https://github.com/dequelabs/axe-core/issues)?

AFAICT axe should be saying these are valid unless there's something I'm missing.
image

@calder12
Copy link
Author

Thanks @calder12! I can confirm this behavior with axe-core 3.1.2. Would you mind filing this in the appropriate repository (https://github.com/dequelabs/axe-core/issues)?

AFAICT axe should be saying these are valid unless there's something I'm missing.
image

Turns out there has been an issue open on this in axe-core since October.
dequelabs/axe-core#1176

@brendankenny
Copy link
Member

Unclear exactly when this shipped in axe-core, but looks all good in latest Lighthouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants