Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse fails to flag a 24MP image #7236

Closed
patrickhulce opened this issue Feb 13, 2019 · 1 comment · Fixed by #10506
Closed

Lighthouse fails to flag a 24MP image #7236

patrickhulce opened this issue Feb 13, 2019 · 1 comment · Fixed by #10506
Assignees
Labels

Comments

@patrickhulce
Copy link
Collaborator

Provide the steps to reproduce

  1. Run LH on https://www.portuguesetrails.com/en
  2. Observe the horrifying 33 MB of images it loads
  3. Look through all the image opportunity audits for their whopping 24 megapixel image https://www.portuguesetrails.com/sites/default/files/gallery/iStock-621859064BicicletasPraia_AG_PT_moedas1.jpg whose dimensions are 6000x4000

What is the current behavior?

Lighthouse does not flag this image as being massive.

What is the expected behavior?

Lighthouse flags this image.

I'm not really sure what to specifically do about this one though. It falls through the cracks because...

  • It passes optimized images because for a 24MP image, it is fairly well compressed at only 2 MB.
  • It passes webp images for the same reason.
  • It passes "use responsive images" because it is offscreen and has client dimensions of 0.
  • It passes "use offscreen" because it is requested after TTI.

I don't really want to change any of those constraints in our existing audits, so it feels like there's just a hole in our coverage for "this image is just way too big".

Related issues
#7173

@patrickhulce
Copy link
Collaborator Author

We decided to count images that are offscreen in the "use-responsive-images" audit with an assumed display size of the entire screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants