Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation messing up linked docs in dom-size #9000

Closed
exterkamp opened this issue May 20, 2019 · 4 comments
Closed

Translation messing up linked docs in dom-size #9000

exterkamp opened this issue May 20, 2019 · 4 comments
Assignees
Labels
chillin ❄ i18n internationalization thangs needs-priority

Comments

@exterkamp
Copy link
Member

exterkamp commented May 20, 2019

Run LH with --locale=🇫🇷 and look @ dom-size:
image

This highlights a larger problem with embedded HTML content in translated strings. Which should be removed from the translated part and added in on our end at report-time (maybe?) so that this doesn't happen and we stop paying to translate these links that aren't really translated.

@exterkamp exterkamp self-assigned this May 20, 2019
@exterkamp exterkamp added the i18n internationalization thangs label May 20, 2019
@exterkamp exterkamp changed the title 🇫🇷 Translation messing up linked docs in dom-size Translation messing up linked docs in dom-size May 20, 2019
@exterkamp exterkamp added the bug label May 20, 2019
@patrickhulce
Copy link
Collaborator

Which should be removed from the translated part and added in on our end at report-time (maybe?) so that this doesn't happen and we stop paying to translate these links that aren't really translated.

Not sure I follow this one. Seems like the translators just need to learn how to use markdown though so we know which words to actually link? Markdown or some other annotation format that seems more complicated cuz markdown is as simple as it gets :)

@brendankenny
Copy link
Member

kind of part of #6945.

There is a recommended <a> format (at least it's in a lot of the docs). We could translate to it and back for string submission.

@exterkamp
Copy link
Member Author

This was fixed in #8999 manually, but we need to re-upload it to translation for official correction in the tc/ system.

@exterkamp
Copy link
Member Author

Collapsing into #9197 since it is the same thing and will be closed with that resolving soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chillin ❄ i18n internationalization thangs needs-priority
Projects
None yet
Development

No branches or pull requests

3 participants