-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can Lighthouse Plugins specify URL query parameters #9754
Comments
You could define a new pass in your config, and have a gatherer run some JS to redirect the page. doing that in or, you could forget the extra pass, and just have your gatherer call If you want to use request headers instead, there's |
@connorjclark I think @t-kelly was hoping to do this in a plugin though, so the short answer is we do not plan on enabling plugins to do this outside of the |
This is true. And trying to stay away from custom configs so that using the plugin is as easy as specifying it/enabling it.
I like this because it's simple and should work. The audits don't need to observe browser behaviour with this additional page attribution, just access specific page content which is totally achievable with an extra request. Thanks all! |
Summary
Want to expose additional HTML page attribution needed for Lighthouse plugin audits. Thought a query parameter would be the easiest way of triggering this. Can a Lighthouse Plugin:
a) Execute on an independent page load instance so these additional attribution doesn't impact other audits (e.g don't want additional HTML bytes to impact performance audits)?
b) Modify the input URL as needed (e.g. add query parameters)?
The text was updated successfully, but these errors were encountered: