From 5eae70852de8bdad5816f1dc95acb39d97a60ec8 Mon Sep 17 00:00:00 2001 From: Adam Raine Date: Tue, 13 Dec 2022 18:59:54 -0800 Subject: [PATCH] tests(devtools): use correct build folder for e2e tests --- core/test/devtools-tests/run-e2e-tests.sh | 3 ++- third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts | 2 +- third-party/devtools-tests/e2e/lighthouse/timespan_test.ts | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/core/test/devtools-tests/run-e2e-tests.sh b/core/test/devtools-tests/run-e2e-tests.sh index 84d67d104767..80013e2a0642 100644 --- a/core/test/devtools-tests/run-e2e-tests.sh +++ b/core/test/devtools-tests/run-e2e-tests.sh @@ -9,9 +9,10 @@ set -euo pipefail SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" +BUILD_FOLDER="${BUILD_FOLDER:-LighthouseIntegration}" export LH_ROOT="$SCRIPT_DIR/../../.." cd "$DEVTOOLS_PATH" TEST_PATTERN="${1:-lighthouse/*}" -npm run e2etest -- "$TEST_PATTERN" +npm run e2etest -- "$TEST_PATTERN" --target=$BUILD_FOLDER diff --git a/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts b/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts index b1d990062552..ab490c6a6088 100644 --- a/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts +++ b/third-party/devtools-tests/e2e/lighthouse/snapshot_test.ts @@ -77,7 +77,7 @@ describe('Snapshot', async function() { }); const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr); - assert.strictEqual(auditResults.length, 73); + assert.strictEqual(auditResults.length, 72); assert.strictEqual(erroredAudits.length, 0); assert.deepStrictEqual(failedAudits.map(audit => audit.id), [ 'document-title', diff --git a/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts b/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts index f3fe1c76c9c2..c6110793c7f7 100644 --- a/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts +++ b/third-party/devtools-tests/e2e/lighthouse/timespan_test.ts @@ -84,7 +84,7 @@ describe('Timespan', async function() { assert.strictEqual(devicePixelRatio, 1); const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr); - assert.strictEqual(auditResults.length, 47); + assert.strictEqual(auditResults.length, 46); assert.strictEqual(erroredAudits.length, 0); assert.deepStrictEqual(failedAudits.map(audit => audit.id), []);