docs(puppeteer-chromium): docker alpine switch to Alpine 3.10 #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitaliytv
changed the title
aslushnikov
reviewed
Jun 29, 2019
|
Yes please! Right now the chromium version on edge changed, what specified in the docs doesn't work anymore 😟 |
aslushnikov
approved these changes
Aug 10, 2019
|
@vitaliytv sorry for this taking so long. May I ask you to re-baseline this atop of master and force-push it to the PR? |
|
@aslushnikov maybe with chromium 76? |
vitaliytv
commented
Aug 11, 2019
There was a problem hiding this comment.
@vitaliytv sorry for this taking so long. May I ask you to re-baseline this atop of master and force-push it to the PR?
@aslushnikov done, with chromium 76
This was referenced Dec 4, 2019
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without EDGE