feat(api): add element.select and element.evaluate for consistency #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
evalselect
branch
from
12c5094
to
3f39f6d
Compare
pavelfeldman
changed the title
pavelfeldman
force-pushed
the
evalselect
branch
from
3f39f6d
to
06a6617
Compare
dgozman
reviewed
Aug 29, 2019
| @@ -237,6 +237,7 @@ | |||
| - [class: JSHandle](#class-jshandle) | |||
| * [jsHandle.asElement()](#jshandleaselement) | |||
| * [jsHandle.dispose()](#jshandledispose) | |||
| * [jsHandle.evaluate(pageFunction[, ...args])](#jshandleevaluatepagefunction-args) | |||
There was a problem hiding this comment.
What about evaluateHandle, while we are here?
pavelfeldman
force-pushed
the
evalselect
branch
from
06a6617
to
3dc429e
Compare
docs/api.md
Outdated
|
|
||
| This method passes this handle as the first argument to `pageFunction`. | ||
|
|
||
| If `pageFunction` returns a [Promise], then `handle.eval` would wait for the promise to resolve and return its value. |
There was a problem hiding this comment.
Suggested change
| If `pageFunction` returns a [Promise], then `handle.eval` would wait for the promise to resolve and return its value. | |
| If `pageFunction` returns a [Promise], then `handle.evaluate` would wait for the promise to resolve and return its value. |
aslushnikov
approved these changes
Sep 4, 2019
pavelfeldman
force-pushed
the
evalselect
branch
from
3dc429e
to
a31fd7a
Compare
pavelfeldman
force-pushed
the
evalselect
branch
from
a31fd7a
to
d832f48
Compare
This was referenced Dec 4, 2019
rfojtik
pushed a commit
to rfojtik/puppeteer
that referenced
this pull request
Dec 21, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.