feat: refactor scripts and realms and fix generator serialization #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
force-pushed
the
thiagowfx/serialization
branch
4 times, most recently
from
aeeb902
to
19dea76
Compare
|
It turns out ScriptEvaluator and Realm deal with the same domains. I decided to merge them, for ease of readability. And then did some refactoring to try to make function and variable names easier to read. There's still more refactoring that can be done, but that's it for now. |
jrandolf-2
force-pushed
the
thiagowfx/serialization
branch
from
19dea76
to
4c99c6a
Compare
thiagowfx
force-pushed
the
thiagowfx/serialization
branch
from
4c99c6a
to
b417b0b
Compare
|
Yay, all tests are passing. Let me see if I can refactor it a bit more. |
thiagowfx
force-pushed
the
thiagowfx/serialization
branch
from
a53b4b4
to
e280027
Compare
added 6 commits
July 12, 2023 18:13
thiagowfx
force-pushed
the
thiagowfx/serialization
branch
from
e280027
to
7323a1d
Compare
Lightning00Blade
pushed a commit
that referenced
this pull request
Jul 21, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.18](chromium-bidi-v0.4.17...chromium-bidi-v0.4.18) (2023-07-21) ### Features * implement browsingContext.activate ([#1002](#1002)) ([22e2417](22e2417)) * implement drag n' drop ([#1006](#1006)) ([6443045](6443045)) * **print:** throw unsupported operation when content area is empty ([#992](#992)) ([71a8b5c](71a8b5c)), closes [#518](#518) * refactor scripts and realms and fix generator serialization ([#1013](#1013)) ([73ea6f0](73ea6f0)), closes [#562](#562) * support iterator serialization ([#1042](#1042)) ([9dff121](9dff121)) ### Bug Fixes * don't hold finished requests in memory ([#1058](#1058)) ([f15163a](f15163a)) * NavigationStarted Event for sub-frames ([#1009](#1009)) ([c4841f8](c4841f8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #562