feat(add network intercept): parse URL patterns #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
force-pushed
the
thiagowfx/network-interception
branch
3 times, most recently
from
fe20155
to
d74a0f6
Compare
|
Still a draft, but feel free to start to review it. |
OrKoN
approved these changes
Aug 21, 2023
Lightning00Blade
approved these changes
Aug 21, 2023
thiagowfx
force-pushed
the
thiagowfx/network-interception
branch
2 times, most recently
from
6f88da0
to
1a15caa
Compare
|
In principle this could already be merged, but there are a couple of edge cases still missing (even though all WPT tests are passing). I added a few more WPT tests: web-platform-tests/wpt#41558, but I expect there are couple more missing. |
added 14 commits
August 23, 2023 11:24
Bug: #644 Doc: [go/webdriver-bidi:network-request-interception-proposal](http://go/webdriver-bidi:network-request-interception-proposal) Spec: https://w3c.github.io/webdriver-bidi/#network-intercepts
thiagowfx
force-pushed
the
thiagowfx/network-interception
branch
from
1a15caa
to
ba6b2ca
Compare
|
Will address leftovers in a follow-up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #644
Doc: go/webdriver-bidi:network-request-interception-proposal
Spec: https://w3c.github.io/webdriver-bidi/#network-intercepts