fix: reject errors instead of throwing in CDP target init #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
force-pushed
the
jrandolf/reject-instead-of-throw
branch
from
97b0db1
to
b7eb2eb
Compare
jrandolf-2
force-pushed
the
jrandolf/reject-instead-of-throw
branch
from
b7eb2eb
to
70d3a80
Compare
OrKoN
approved these changes
Sep 7, 2023
thiagowfx
reviewed
Sep 7, 2023
jrandolf-2
force-pushed
the
jrandolf/reject-instead-of-throw
branch
from
70d3a80
to
202bff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.