Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support redirect response #1313

Merged
merged 2 commits into from
Sep 19, 2023
Merged

feat: support redirect response #1313

merged 2 commits into from
Sep 19, 2023

Conversation

Lightning00Blade
Copy link
Collaborator

No description provided.

thiagowfx
thiagowfx reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@thiagowfx thiagowfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this make some test pass, and/or should we add one?

(It's OK to do it in another PR, but we should have at least one test for redirection if feasible. Feasible = we may need a local server, which we don't have support for yet...)

@Lightning00Blade
Copy link
Collaborator Author

Tests are failing as Headful auto updates http to https I will look into WPT if there is a test that can confirm this behavior and if not add it.

@Lightning00Blade Lightning00Blade merged commit 7c17942 into main Sep 19, 2023
16 checks passed
@Lightning00Blade Lightning00Blade deleted the redirect-response branch September 19, 2023 16:05
@release-please release-please bot mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagowfx thiagowfx thiagowfx approved these changes

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lightning00Blade @OrKoN @thiagowfx