Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate click count by button #1321

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: separate click count by button #1321

merged 1 commit into from
Sep 20, 2023

Conversation

jrandolf-2
Copy link
Contributor

Previously, the click count was measured globally among all buttons. This was incorrect as browsers separate click count by button.

Copy link
Collaborator

@Lightning00Blade Lightning00Blade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do you think this will help with falkyness we have observed?

Previously, the click count was measured globally among all buttons. This was incorrect as browsers separate click count by button.
@jrandolf-2 jrandolf-2 merged commit 9ebf2ed into main Sep 20, 2023
13 of 14 checks passed
@jrandolf-2 jrandolf-2 deleted the jrandolf/click-count branch September 20, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants