feat: implement permissions #1645
Merged
+317
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/permissions
branch
5 times, most recently
from
76163f5
to
4db096b
Compare
OrKoN
force-pushed
the
orkon/permissions
branch
9 times, most recently
from
46c73aa
to
89735f7
Compare
|
Please add some e2e tests |
OrKoN
force-pushed
the
orkon/permissions
branch
from
89735f7
to
3df6d10
Compare
|
Do you know any Chrome-specific permissions tests we could add? |
|
Added a happy path e2e test. |
sadym-chromium
approved these changes
Jan 16, 2024
OrKoN
force-pushed
the
orkon/permissions
branch
4 times, most recently
from
8a94d41
to
5591cbe
Compare
Co-authored-by: Maksim Sadym <[email protected]>
Co-authored-by: Maksim Sadym <[email protected]>
OrKoN
force-pushed
the
orkon/permissions
branch
from
5591cbe
to
ce76cee
Compare
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.4](chromium-bidi-v0.5.3...chromium-bidi-v0.5.4) (2024-01-17) ### Features * implement `Input.setFiles` ([#1705](#1705)) ([50d1921](50d1921)) * implement `storage.getCookies` and `storage.setCookie` ([#1593](#1593)) ([2b08660](2b08660)) * implement permissions ([#1645](#1645)) ([29c7b0b](29c7b0b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: https://www.w3.org/TR/permissions/#automation-webdriver-bidi
Tests: web-platform-tests/wpt#43802