feat: return all cookies for a given browsing context #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/cookies-partition-2
branch
2 times, most recently
from
27095fa
to
fe506c9
Compare
added 4 commits
January 24, 2024 14:37
Return all the cookies if `getCookies` is called with `BrowsingContextPartitionDescriptor` is called, not only a partitioned one originated from it.
sadym-chromium
force-pushed
the
sadym/cookies-partition-2
branch
from
9eff75e
to
6b17105
Compare
OrKoN
approved these changes
Jan 24, 2024
OrKoN
approved these changes
Jan 24, 2024
sadym-chromium
added a commit
that referenced
this pull request
Jan 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.5](chromium-bidi-v0.5.4...chromium-bidi-v0.5.5) (2024-01-25) ### Features * allow not partitioned cookies ([#1718](#1718)) ([d54a4f1](d54a4f1)) * implement user contexts ([#1715](#1715)) ([b75def3](b75def3)) * provide logs before Mapper is launched via NodeJS runner ([#1737](#1737)) ([0b278f3](0b278f3)) * return all cookies for a given browsing context ([#1746](#1746)) ([456d947](456d947)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Maksim Sadym <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return all the cookies if
getCookiesis called withBrowsingContextPartitionDescriptoris called, not only a partitioned one originated from it.As per spec:
While:
In our case the "associated storage partition" is only a
UserContext, support of which is out of scope yet.