fix: allow shift with printable keys #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
force-pushed
the
jrandolf/use-shift
branch
from
5401b02
to
c6b2d82
Compare
OrKoN
approved these changes
Jun 28, 2023
jrandolf-2
force-pushed
the
jrandolf/use-shift
branch
from
c6b2d82
to
2e2de48
Compare
auto-merge was automatically disabled
June 28, 2023 09:31
Merge queue setting changed
jrandolf-2
force-pushed
the
jrandolf/use-shift
branch
from
2e2de48
to
b8235b6
Compare
jrandolf-2
pushed a commit
that referenced
this pull request
Jun 28, 2023
🤖 I have created a release *beep* *boop* --- ## [0.4.15](chromium-bidi-v0.4.14...chromium-bidi-v0.4.15) (2023-06-28) ### Features * add `browsingContext.navigationStarted'` ([#881](#881)) ([db5a1cc](db5a1cc)) ### Bug Fixes * allow shift with printable keys ([#906](#906)) ([5ec0ba2](5ec0ba2)) * expand viewport validation tests ([#895](#895)) ([7cc5aee](7cc5aee)), closes [#868](#868) * use correct location for key events ([#903](#903)) ([88be8e3](88be8e3)) * use correct modifiers for mouse click ([#904](#904)) ([9561fff](9561fff)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.