fix: improve :where supports check #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer Firefox's have :where support but the specific check used returns
false. Changing the check to be `CSS.supports('selector(:where(div))')`
makes it return `true` in Firefox and makes the polyfill work there
without needing the :where fallback.
Fixes GoogleChromeLabs#64
This was referenced Oct 25, 2022
lilles
approved these changes
Nov 2, 2022
|
Right, this is necessary because Firefox implemented the spec change to always parse selectors as non-forgiving per this resolution: w3c/csswg-drafts#7280 (comment) |
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer Firefox's have :where support but the specific check used returns false. Changing the check to be
CSS.supports('selector(:where(div))')makes it returntruein Firefox and makes the polyfill work there without needing the :where fallback.Fixes #64