Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base Go Version and Docker image tag on Git commit sha #21

Closed
2 tasks done
markmandel opened this issue Dec 11, 2017 · 0 comments
Closed
2 tasks done

Base Go Version and Docker image tag on Git commit sha #21

markmandel opened this issue Dec 11, 2017 · 0 comments
Assignees
@markmandel
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/design Proposal discussing new features / fixes and how they should be implemented
Milestone
0.1

Comments

@markmandel
Copy link
Member

markmandel commented Dec 11, 2017 •
edited
Loading

Depends on:

Make the Version Makefile variable the first the first a number value (0.1-) + the first 7(?) characters of the Git hash for the deployed version.

This should be passed into the Go compilation as ldflags -X to overwrite it' value.
This should also be used as the tag to push up to the docker registry, so there is always a specific version being run.

The build/Makefile will need an install target to that will need some kind of templating to push this through to the install.yaml and kubectl apply - sed may be a simple and easy first step.

Optional: Make the imagePullPolicy dependent on an extra argument? just as make install DEV=true or something similar? The developer experience should be considered here. Not sure the best approach for that.
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/design Proposal discussing new features / fixes and how they should be implemented labels Dec 11, 2017
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Consolidate the Version constant
b4d29c3 
This puts the Version in a single place,
which is a setup for #21, and means there will
always be constant version information across
all the moving pieces.

Closes #2
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Consolidate the Version constant
57db13f 
This puts the Version in a single place,
which is a setup for #21, and means there will
always be constant version information across
all the moving pieces.

Closes #2
@markmandel markmandel mentioned this issue Dec 13, 2017
Merged
@markmandel markmandel self-assigned this Dec 13, 2017
markmandel added a commit that referenced this issue Dec 14, 2017
@markmandel
Implement Versioning for dev and release
4fa8258 
When working in development, images and go binaries
will be versioned with the git hash.

On release the version can be overwritten in the `build/Makefile`
to explicitly set the version.

Closes #21
markmandel added a commit that referenced this issue Dec 14, 2017
@markmandel
Implement Versioning for dev and release
a1acea4 
When working in development, images and go binaries
will be versioned with the git hash.

On release the version can be overwritten in the `build/Makefile`
to explicitly set the version.

Closes #21
@markmandel markmandel mentioned this issue Dec 14, 2017
Merged
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.1 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/design Proposal discussing new features / fixes and how they should be implemented
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@markmandel