New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle SIGTERM in Controller #33

Closed

markmandel opened this issue Dec 20, 2017 · 1 comment

Labels

kind/bug

Milestone

Member

markmandel commented Dec 20, 2017 •

edited

Loading

Currently the controller doesn't shutdown gracefully on SIGTERM.

It should do that.

There is https://github.com/googleprivate/agon/blob/master/gameservers/controller/main.go#L90
But it doesn't seem to work?

markmandel added the kind/bug label

markmandel added this to the 0.1 milestone

Member Author

markmandel commented Jan 5, 2018

This seems to be fixed now. I wonder if the change in ENTRYPOINT did it?

Closing, will reopen if it starts happening again.

markmandel closed this as completed

markmandel mentioned this issue

Target for generating a CHANGELOG from GitHub Milestones. #217

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment