Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ENTRYPOINT foo to ENTRYPOINT ["/path/foo"] #39

Closed
markmandel opened this issue Dec 26, 2017 · 0 comments
Closed

Convert ENTRYPOINT foo to ENTRYPOINT ["/path/foo"] #39

markmandel opened this issue Dec 26, 2017 · 0 comments
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc kind/design Proposal discussing new features / fixes and how they should be implemented
Milestone

Comments

@markmandel
Copy link
Member

markmandel commented Dec 26, 2017

This is why we couldn't pass arguments to the controller and sidecar.

This should be switched to using the array notation (which is actually preferred)

Review the sidecar - look to convert to flags rather than environment variables.

@markmandel markmandel added good first issue These are great first issues. If you are looking for a place to start, start here! kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc kind/design Proposal discussing new features / fixes and how they should be implemented labels Dec 26, 2017
@markmandel markmandel added this to the 0.1 milestone Jan 3, 2018
markmandel added a commit that referenced this issue Jan 3, 2018
This will allow passing of flag arguments
if so desired.

Closes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc kind/design Proposal discussing new features / fixes and how they should be implemented
Projects
None yet
Development

No branches or pull requests

1 participant