Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcloud docker --authorize make target and push targets #5

Closed
markmandel opened this issue Dec 7, 2017 · 0 comments
Closed

gcloud docker --authorize make target and push targets #5

markmandel opened this issue Dec 7, 2017 · 0 comments
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! kind/feature New features for Agones
Milestone
0.1

Comments

@markmandel
Copy link
Member

For a nicer experience on GCP, write a make target that mounts the appropriate docker config files for gcloud docker --authorize-only, and then we can add a series of push commands for the controller and sidercar images that use the standard docker push commands.

Mean you can do a make gcloud-docker-auth build push and all the new versions up on the repository.
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! kind/feature New features for Agones labels Dec 7, 2017
@markmandel markmandel mentioned this issue Dec 11, 2017
Closed
2 tasks
markmandel added a commit that referenced this issue Dec 13, 2017
@markmandel
Make targets gcloud docker --authorize-only and push
09c0888 
This makes sure we can also write generic `docker push`
commands in our makefile, which will work across providers
and registeries. Also speeds up development!

Closes #5
@markmandel markmandel mentioned this issue Dec 13, 2017
Merged
@markmandel markmandel mentioned this issue May 22, 2018
Merged
@markmandel markmandel added this to the 0.1 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. good first issue These are great first issues. If you are looking for a place to start, start here! kind/feature New features for Agones
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@markmandel